[TASK] Add ProcessorSkipperTest for processor skipping functionality#391
Merged
simonschaufi merged 2 commits intoandreaswolf:mainfrom Mar 31, 2026
Merged
Conversation
Contributor
chrissonntag
commented
Mar 31, 2026
chrissonntag
commented
- 🧪 Implement tests to verify processors not in skip list are not skipped
- ✅ Add tests for single processor in skip list being skipped
- 🔄 Ensure other processors are unaffected when one is skipped
- 🚀 Test multiple processors can be skipped simultaneously
- ✔️ Validate all processors can be skipped when configured
- 🧪 Implement tests to verify processors not in skip list are not skipped - ✅ Add tests for single processor in skip list being skipped - 🔄 Ensure other processors are unaffected when one is skipped - 🚀 Test multiple processors can be skipped simultaneously - ✔️ Validate all processors can be skipped when configured
Contributor
Author
|
Don't know where the tests have vanished to. Most likely they have been a casualty of the rebasing... However, now they are back |
Collaborator
|
Please tell your AI not to use emojis. And then fix the CI ;) |
Remove unnecessary generic type annotation from ProcessorSkipper::shouldSkip() since the method only performs a string comparison via in_array(). This resolves PHPStan covariance errors when passing concrete FileProcessor class-strings in tests.
Contributor
Author
|
Copy that. No emojis from now on and tests are fixed :) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.